-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add code to run OG-USA #56
base: master
Are you sure you want to change the base?
Conversation
I believe that this PR is ready for review. As the first step in fully integrating OG-USA into Tax-Brain, all I've tried to do here is apply the percentage change in wage growth rates to the default rates. Additional outputs related to OG-USA such as new graphs/tables will come in another PR and I'm open to suggestions as to what those would be. Adding OG-USA to COMP will also come in a later PR. |
@andersonfrailey, We should have been on this for you! I'm getting my head around TB now and can probably help with this PR (or create a new one) at this point. Let me know. |
Thanks, @jdebacker! Can you take a look at what we've got here? It'd be great if we could just fix the conflicts here, but no biggie if it's easier to just start fresh. |
@andersonfrailey Yes, can you fix the conflicts, then I'll checkout the branch and make a few tweaks to |
@jdebacker, conflicts are taken care of |
@andersonfrailey Ok - I'm working on this on your branch. I'll push my changes to that. BUT, I'm having some issues getting Tax-Brain to run generally. Maybe the best place to get me started there is there make sure I can run the testing suite from my master branch. Can you take a look at the issue I describe in PR #160 and see if you can replicate that or know of the possible issue. FYI, When I was trying to test my OG-USA integration changes, I was unable import
|
The above is resolved with the new |
Updates to OG-USA integration
This PR adds the code needed to run OG-USA and apply the change in wage growth in taxcalc. Right now, I just run OG-USA using the parameters from the example and the user opts to run OG-USA with a boolean argument. Future updates will be needed to add custom parameter support for both the Python API and the COMP web app.
I still need to do more robust checks to make sure everything is being applied correctly and would appreciate feedback from others.
cc @MattHJensen @jdebacker @rickecon