Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request to merge MAGNET into dev branch #975

Open
wants to merge 141 commits into
base: dev
Choose a base branch
from

Wrote a bunch of unit tests for magnet

12580b2
Select commit
Loading
Failed to load commit list.
Open

Pull request to merge MAGNET into dev branch #975

Wrote a bunch of unit tests for magnet
12580b2
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor failed Jul 10, 2024 in 5s

11 issues found.

Annotations

Check notice on line 583 in src/porespy/networks/_magnet.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/porespy/networks/_magnet.py#L583 

Multiple spaces after operator. (E222)

Check notice on line 584 in src/porespy/networks/_magnet.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/porespy/networks/_magnet.py#L584 

Multiple spaces after operator. (E222)

Check notice on line 161 in src/porespy/metrics/_funcs.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/porespy/metrics/_funcs.py#L161 

Unresolved comment '# TODO: this function is a prime target for parallelization since the'. (C100)

Check notice on line 658 in src/porespy/filters/_snows.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/porespy/filters/_snows.py#L658 

Unresolved comment '# TODO: use dask ProgressBar once compatible w/ logging.' (C100)

Check notice on line 494 in test/unit/test_filters.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

test/unit/test_filters.py#L494 

Unresolved comment '# TODO: This is failing on github'. (C100)

Check notice on line 502 in test/unit/test_filters.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

test/unit/test_filters.py#L502 

Unresolved comment '# TODO: These are failing on github'. (C100)

Check notice on line 309 in src/porespy/generators/_micromodels.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/porespy/generators/_micromodels.py#L309 

Unresolved comment '# TODO: The corners contain 2 (say A and B) points very close to each other.' (C100)

Check notice on line 66 in test/unit/test_simulations.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

test/unit/test_simulations.py#L66 

Multiple spaces after ','. (E241)

Check notice on line 70 in test/unit/test_simulations.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

test/unit/test_simulations.py#L70 

Multiple spaces after ','. (E241)

Check notice on line 77 in test/unit/test_simulations.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

test/unit/test_simulations.py#L77 

Multiple spaces after ','. (E241)

Check notice on line 28 in src/porespy/__init__.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/porespy/__init__.py#L28 

Unresolved comment '# TODO: Deprecate dns module once v3 is out'. (C100)
View more details on codefactor.io