바텀시트 Constraint 리팩토링 + 애니메이션 코드 적용 #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bottom 대신에 top으로 제약조건이 잡히도록 수정했습니다. 이렇게 두면, 기준값이 top이 되기 때문에 나중에 사용자가 grabber를 잡아당길 때 끌려 올라가는 애니메이션을 줄 수 있게 됩니다.
- present 및 dismiss의 애니메이션을 true로 설정 - presentationStyle 제거
- SortType initializer를 제거하고, String타입의 text를 받는 initializer를 구현 -> 다른 곳에서 재사용 가능
WhiteHyun
added
🍎 ConfigureUI
dlrjswns
approved these changes
May 9, 2023
Comment on lines
24
to
27
| contentView.snp.makeConstraints { | ||
| $0.leading.trailing.equalToSuperview() | ||
| $0.bottom.equalTo(view.safeAreaLayoutGuide) | ||
| $0.top.equalTo(view.safeAreaLayoutGuide) | ||
| } |
There was a problem hiding this comment.
이 부분 변경으로 앞으로 바텀시트사용할때 바텀이랑 높이 둘다 잡아두면 의도하신대로 구현할 수 있는건가요 ???
There was a problem hiding this comment.
이 부분 변경으로 앞으로 바텀시트사용할때 바텀이랑 높이 둘다 잡아두면 의도하신대로 구현할 수 있는건가요 ???
넵! top, bottom만 잘 맞춰주시면 됩니다!
dlrjswns
reviewed
May 9, 2023
만약 스크린샷에서 하단 모서리 부분을 말씀하시는 거라면 이는 시뮬레이터 녹화할 때 나타나는 특징으로, 아이폰은 둥근 형태이지만 스크린샷은 사각형이기 때문에 어쩔 수 없이 발생하는 것 같더라구요. 테스트하면 잘 동작합니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
animated: false와presentationStyle = .overFullScreen을 제거하고,animated: true로 변경했습니다.🌱 PR 포인트
📸 스크린샷
📮 관련 이슈