Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volumes: add persistent data directories #3

Closed
wants to merge 1 commit into from
Closed

volumes: add persistent data directories #3

wants to merge 1 commit into from

Conversation

RandyMcMillan
Copy link
Member

@RandyMcMillan RandyMcMillan commented Aug 30, 2021

volumes: add persistent data directories

@RandyMcMillan RandyMcMillan changed the title volumes: add tor_torrcdir volumes: add more data directories Aug 30, 2021
@RandyMcMillan RandyMcMillan changed the title volumes: add more data directories volumes: add persistent data directories Aug 30, 2021
@RandyMcMillan
Copy link
Member Author

We can add example/default configs to the data directories.

@RandyMcMillan
Copy link
Member Author

the docker-compose references relative paths that don't exist by default.
This causes an error in docker when starting up.

source: ${PWD}/volumes/bitcoin_datadir

This change addresses the issue.

@rsafier
Copy link
Member

rsafier commented Aug 30, 2021

the docker-compose references relative paths that don't exist by default.
This causes an error in docker when starting up.

source: ${PWD}/volumes/bitcoin_datadir

This change addresses the issue.

if we could improve this so we have a purge of some sort. currently have the install and uninstall scripts doing this

@rsafier
Copy link
Member

rsafier commented Aug 30, 2021

the issue with volumes stuff is if end user is not running as root they don't have access to all the files in the volumes as they tend to be under root how things are wired right now

@asherp
Copy link
Collaborator

asherp commented Aug 30, 2021

the issue with volumes stuff is if end user is not running as root they don't have access to all the files in the volumes as they tend to be under root how things are wired right now

I am not seeing this issue on my mac. I created a non-admin account and followed all the install steps from the README.md after pulling this branch. The only thing I needed admin permission for was the initial install of docker. Am I testing this right?

@RandyMcMillan
Copy link
Member Author

ok - I didnt realize it was a file permissions issue - there is a fix for this - i will take another look.

@rsafier
Copy link
Member

rsafier commented Aug 30, 2021

the issue with volumes stuff is if end user is not running as root they don't have access to all the files in the volumes as they tend to be under root how things are wired right now

I am not seeing this issue on my mac. I created a non-admin account and followed all the install steps from the README.md after pulling this branch. The only thing I needed admin permission for was the initial install of docker. Am I testing this right?

so after you make lnd wallet go look into the chain or other directory they are root, at least on normal linux box

@rsafier
Copy link
Member

rsafier commented Aug 30, 2021

the defaults also are already in the docker containers so having a hard time understanding why we would want to do this, perhaps a CH voice chat would be easier to discuss and make me understand advantages

@RandyMcMillan RandyMcMillan marked this pull request as draft September 4, 2021 00:17
@asherp
Copy link
Collaborator

asherp commented Sep 4, 2021

#7 may help resolve linux permissions issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants