feat: User defined initializers in struct definition (for polymorphism) #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still not working, but a base skeleton is available at least Co-authored-by: Ghaith Hachem <[email protected]>
A very basic example as seen below will now work
```
VAR_GLOBAL
globalVar : DINT := 10;
END_VAR
TYPE Parent:
STRUCT
foo : REF_TO DINT;
END_STRUCT
END_TYPE
TYPE Child:
STRUCT
instance : Parent := (foo := REF(globalVar));
END_STRUCT
END_TYPE
FUNCTION main
VAR
localChild : Child;
END_VAR
printf('Value: %d$N', localChild.instance.foo^);
END_FUNCTION
```
For that to work the `indext_struct_type` function needed to add the context defining which struct it currently operates in for the const evaluator to copy over into the `InitData` struct.
Also the resolver needed some extra logic with regards to the init `self` argument, though not entirely sure if needed (specifically the `resolve_reference_expression` needs to match on a `ReferenceExpr`?)
Finally there still seems to be some issues regarding the const evaluator, since one validation ("Some initial values were not generated") reported an error.
Still, a first prototype 🎉
volsa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(For now only prioritize polymorphism use-cases in this PR)
Tasks
foo := (bar := (a := 5))init_barneeds to be called beforea := 5can be initializeda : DINT := '🥸';within a struct definition doesn't trigger any validation errors :( (Perhaps create an issue, since this is not too important for polymorphism)