Use the simde header library for non-x86 compatibility #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nileshpatra
changed the title
Well, due to the use of SIMD intrinsics, yes :-) |
mr-c
reviewed
Jan 30, 2021
| @@ -37,7 +37,7 @@ if (debug) | |||
| set (LIBRARY_COMPILE_DEFINITIONS "${LIBRARY_COMPILE_DEFINITIONS} -g -p") | |||
| message("-- COMPILATION IN DEBUG MODE") | |||
| else() | |||
| set (LIBRARY_COMPILE_DEFINITIONS "${LIBRARY_COMPILE_DEFINITIONS} -O3 -funroll-loops -fomit-frame-pointer -msse3 ") | |||
| set (LIBRARY_COMPILE_DEFINITIONS "${LIBRARY_COMPILE_DEFINITIONS} -O3 -funroll-loops -fomit-frame-pointer") | |||
There was a problem hiding this comment.
-msse3 can stay; we'll handle it different in the Debian package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, plast builds only on x86 arches, using simde, I've attempted to make it build across more arches.
Achieved success on: amd64, arm64, armhf, armel, mipel, mips64el, i386, riscv64 and several other arches.
cc: @ivajloip @cdeltel