Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support metadrive env #328

Merged
merged 9 commits into from
May 4, 2024
Merged

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Apr 21, 2024

Description

This PR is already complete in terms of implementation accuracy. We will merge it shortly after improving the code style and documentation.

This PR supports SafeMetaDrive from MetaDrive[1].

[1]: Metadrive: Composing diverse driving scenarios for generalizable reinforcement learning

Autonomous driving is an important application of reinforcement learning algorithms, and safety is particularly crucial. Safety constraints for autonomous driving tasks are an important research direction in the SafeRL field. We have implemented the embedding of SafeMetaDrive based on our customized environment interface (more details in #310 ) and presented the SafeRL baseline algorithms involved in the MetaDrive paper as follows, hoping to inspire research on related algorithms.

image

Motivation and Context

Related issues can be found at #262

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.83%. Comparing base (924f74c) to head (bd62803).

Files Patch % Lines
omnisafe/evaluator.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   96.84%   96.83%   -0.01%     
==========================================
  Files         138      138              
  Lines        7060     7071      +11     
==========================================
+ Hits         6837     6847      +10     
- Misses        223      224       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gaiejj Gaiejj marked this pull request as ready for review April 22, 2024 05:18
Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj merged commit 93d4975 into PKU-Alignment:main May 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants