Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: pin pandas version #276

Merged
merged 1 commit into from
Sep 9, 2023
Merged

deps: pin pandas version #276

merged 1 commit into from
Sep 9, 2023

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Sep 6, 2023

Description

Pin the version of pandas as 2.0.3.

Motivation and Context

Since the seaborn host in pypi do not support the latest version of pandas, some warning may arise in Python version higher than 3.9, like:

FAILED test_policy.py::test_workflow_for_training[algo(PPO)] - FutureWarning: is_categorical_dtype is deprecated and will be removed in a future version. Use isinstance(dtype, CategoricalDtype) instead
FAILED test_policy.py::test_workflow_for_training[algo(SAC)] - FutureWarning: is_categorical_dtype is deprecated and will be removed in a future version. Use isinstance(dtype, CategoricalDtype) instead
FAILED test_policy.py::test_workflow_for_training[algo(PPOLag)] - FutureWarning: is_categorical_dtype is deprecated and will be removed in a future version. Use isinstance(dtype, CategoricalDtype) instead

For more details please refer to here.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@Gaiejj Gaiejj added bug Something isn't working dependency Something related to package dependencies labels Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #276 (79c60e8) into main (368f84d) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 79c60e8 differs from pull request most recent head 37d380b. Consider uploading reports for the commit 37d380b to get more accurate results

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   97.01%   97.00%   -0.01%     
==========================================
  Files         138      138              
  Lines        6991     6991              
==========================================
- Hits         6782     6781       -1     
- Misses        209      210       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj merged commit db34e2c into PKU-Alignment:main Sep 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependency Something related to package dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants