refactor: cleanup code twice calling #4499
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleibman
requested changes
Jun 4, 2025
| @@ -608,7 +608,7 @@ public function addSheet(Worksheet $worksheet, ?int $sheetIndex = null, bool $re | |||
| */ | |||
| public function removeSheetByIndex(int $sheetIndex): void | |||
| { | |||
| $numSheets = count($this->workSheetCollection); | |||
| $numSheets = $this->getSheetCount(); | |||
There was a problem hiding this comment.
This change seems to add a small amount of overhead through an additional function call. What compensatory advantage do you see that would make this worthwhile?
| if (strcasecmp($this->workSheetCollection[$i]->getTitle(), trim($worksheetName, "'")) === 0) { | ||
| $trimWorksheetName = trim($worksheetName, "'"); | ||
|
|
||
| for ($i = 0; $i < $this->getSheetCount(); ++$i) { |
There was a problem hiding this comment.
This absolutely adds overhead by moving a function call from outside the loop to inside. It will definitely not be approved.
| $trimWorksheetName = trim($worksheetName, "'"); | ||
|
|
||
| for ($i = 0; $i < $this->getSheetCount(); ++$i) { | ||
| if (strcasecmp($this->workSheetCollection[$i]->getTitle(), $trimWorksheetName) === 0) { |
There was a problem hiding this comment.
This one, however, does improve things a bit by moving a function call from inside the loop to outside. I would certainly be okay with including this part.
| $worksheetCount = $this->getSheetCount(); | ||
| for ($i = 0; $i < $worksheetCount; ++$i) { | ||
|
|
||
| for ($i = 0; $i < $this->getSheetCount(); ++$i) { |
There was a problem hiding this comment.
Once again, you are moving a function call from outside the loop to inside. This part of the change will not be approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Just refactoring trimming twice.