Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Clone on Spreadsheet #4370

Merged
merged 6 commits into from
Feb 21, 2025
Merged

Conversation

oleibman
Copy link
Collaborator

Since we have a usable copy method in Spreadsheet, this is probably overkill, especially with serialization now allowed. Nevertheless, I would prefer to not artificially render a standard Php operation (clone) unusable.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Since we have a usable copy method in Spreadsheet, this is probably overkill, especially with serialization now allowed. Nevertheless, I would prefer to not artificially render a standard Php operation (clone) unusable.
An "ambiguity" reported by Version that stopped being ambiguous with Php 7.0. I am very close to dropping this check.
@oleibman oleibman enabled auto-merge February 21, 2025 01:42
@oleibman oleibman added this pull request to the merge queue Feb 21, 2025
Merged via the queue into PHPOffice:master with commit 2661adf Feb 21, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant