Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phpstan Bleeding Edge Part 3: Writer #4369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Phpstan Bleeding Edge Part 3: Writer #4369

wants to merge 1 commit into from

Conversation

oleibman
Copy link
Collaborator

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • code quality

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

@oleibman
Copy link
Collaborator Author

Scrutinizer's new issues are all that it doesn't understand call-string, which is a designation that Phpstan wants us to use. The Scrutinizer issues are now suppressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oleibman