Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sheetState to ListWorksheetInfo Data #4366

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

oleibman
Copy link
Collaborator

Fix #4345. Add a new item to the output array. Although the output is changed, this does not seem like a breaking change to me.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Fix PHPOffice#4345. Add a new item to the output array. Although the output is changed, this does not seem like a breaking change to me.
@oleibman oleibman added this pull request to the merge queue Feb 19, 2025
Merged via the queue into PHPOffice:master with commit 82ac7ab Feb 19, 2025
14 checks passed
@oleibman oleibman deleted the visibility branch February 19, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Include sheet state in listWorksheetInfo
1 participant