IOFactory::identify and Custom Reader/Writer #4361
Merged
+147
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4357.
identify
returns a type, not a class name, and this result is not always usable for createReader. The docs say that it is usable in that manner. Changing the behavior ofidentify
would be a breaking change, but adding an optional parameter (defaulting to current behavior) allowing it to return a class name rather than a type would not. This PR adds that parameter and updates the documentation to suggest its use for the code in question.To complete this change,
createReader
now accepts either a type (current behavior) or class name (new). Although it is not particularly identified as a possible problem by the issue,createWriter
is similarly changed for consistency's sake.This is:
Checklist: