Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Previously Announced Deprecations #4341

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Remove Previously Announced Deprecations #4341

merged 1 commit into from
Feb 6, 2025

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Feb 5, 2025

Remove

  • Worksheet::getHashCode
  • Worksheet::getProtectecCells
  • Worksheet::getStyles
  • Drawing::setIsUrl
  • IReader::SKIP_EMPTY_CELLS
  • Settings:setLibXmlLoaderOptions and getLibXmlLoaderOptions
  • Writer/Html::isMpdf

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • remove deprecated code

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

@oleibman
Remove Previously Announced Deprecations
77815d2 
Remove
- Worksheet::getHashCode
- Worksheet::getProtectecCells
- Worksheet::getStyles
- Drawing::setIsUrl
- IReader::SKIP_EMPTY_CELLS
- Settings:setLibXmlLoaderOptions and getLibXmlLoaderOptions
- Writer/Html::isMpdf
@oleibman oleibman added this pull request to the merge queue Feb 6, 2025
Merged via the queue into PHPOffice:master with commit 06f0b4c Feb 6, 2025
14 checks passed
@oleibman oleibman deleted the deldeprecate branch February 6, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oleibman