Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xls Writer Parser Mis-handling TRUE/FALSE As VLOOKUP Arguments #4333

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

oleibman
Copy link
Collaborator

Fix #4331. Parser treats TRUE/FALSE as functions rather than constants, which is nominally harmless, but it then expects an argument count of 0 and instead sees null-string. Changed to recognize this situation and leave TRUE/FALSE/TRUE()/FALSE() unchanged.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Fix PHPOffice#4331. Parser treats TRUE/FALSE as functions rather than constants, which is nominally harmless, but it then expects an argument count of 0 and instead sees null-string. Changed to recognize this situation and leave TRUE/FALSE/TRUE()/FALSE() unchanged.
@oleibman oleibman enabled auto-merge February 3, 2025 00:12
@oleibman oleibman added this pull request to the merge queue Feb 3, 2025
Merged via the queue into PHPOffice:master with commit e721975 Feb 3, 2025
13 of 14 checks passed
@oleibman oleibman deleted the issue4331 branch February 3, 2025 00:19
oleibman added a commit that referenced this pull request Feb 7, 2025
oleibman added a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

XLS 2003 VSLOOKUP parsing error
1 participant