Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: StrikeThrough property in word2007 #2604

Closed

Conversation

noec764
Copy link

@noec764 noec764 commented Apr 4, 2024

I had a problem with strike through in Word2007.
If a strikethrough style was added to a text element it never appeared in the resulting document.
Indeed, the XML generated was as follows

<w:r>
    <w:rPr>
        <w:strike w:val="1"/>
        <w:dstrike w:val="0"/>
     </w:rPr>
     <w:t xml:space="preserve">some text</w:t>
</w:r>

The statement <w:dstrike w:val="0"/> should not be present here
I figure out that the test $style->isDoubleStrikethrough() !== null is true if $style->isDoubleStrikethrough() === false
So as a text cannot be strike and doublestrike at the same time, word2007 ignores it.

@coveralls
Copy link

Coverage Status

coverage: 97.217%. remained the same
when pulling bde34d3 on noec764:FIX_StrikeThrough_property_Word2007
into 8b891bb on PHPOffice:master.

@Progi1984
Copy link
Member

@noec764 Hi, Could you update the changelog and add some unit tests, please ?

@Progi1984 Progi1984 added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Aug 7, 2024
@Progi1984 Progi1984 linked an issue Aug 15, 2024 that may be closed by this pull request
@Progi1984 Progi1984 added this to the 1.3.0 milestone Aug 15, 2024
@Progi1984
Copy link
Member

Superseeded by #2661

@Progi1984 Progi1984 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for feedback Question has been asked, waiting for response from PR author
Development

Successfully merging this pull request may close these issues.

Strikethrough font style in Word2007 does not work
3 participants