Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve https://github.com/PHP-DI/Slim-Bridge/issues/51 #41

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
},
"require": {
"php": ">=7.3",
"psr/container": "^1.0|^2.0"
"psr/container": "^1.0|^2.0",
"psr/http-server-middleware": "^1.0"
},
"require-dev": {
"phpunit/phpunit": "^9.0",
Expand Down
4 changes: 4 additions & 0 deletions src/CallableResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use Invoker\Exception\NotCallableException;
use Psr\Container\ContainerInterface;
use Psr\Container\NotFoundExceptionInterface;
use Psr\Http\Server\MiddlewareInterface;
use ReflectionException;
use ReflectionMethod;

Expand Down Expand Up @@ -38,6 +39,9 @@ public function resolve($callable): callable
$callable = $this->resolveFromContainer($callable);

if (! is_callable($callable)) {
if ($callable instanceof MiddlewareInterface) {
return fn ($request, $next) => $callable->process($request, $next);
}
throw NotCallableException::fromInvalidCallable($callable, true);
}

Expand Down
18 changes: 18 additions & 0 deletions tests/CallableResolverTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@
use Invoker\Exception\NotCallableException;
use Invoker\Test\Mock\ArrayContainer;
use Invoker\Test\Mock\CallableSpy;
use Invoker\Test\Mock\Psr_15\Middleware;
use Invoker\Test\Mock\Psr_15\Request;
use Invoker\Test\Mock\Psr_15\RequestHandler;
use PHPUnit\Framework\TestCase;
use Psr\Http\Message\ResponseInterface;
use stdClass;

class CallableResolverTest extends TestCase
Expand Down Expand Up @@ -123,6 +127,20 @@ public function resolves_string_method_call_with_service()
$this->assertTrue($fixture->wasCalled);
}

/**
* @test
*/
public function resolves_psr_15_middleware()
{
$this->container->set(Middleware::class, new Middleware());

$result = $this->resolver->resolve(Middleware::class);

$result = $result(new Request(), new RequestHandler());

$this->assertInstanceOf(ResponseInterface::class, $result);
}

/**
* @test
*/
Expand Down
20 changes: 20 additions & 0 deletions tests/Mock/Psr_15/Middleware.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?php

namespace Invoker\Test\Mock\Psr_15;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;

/**
* The mock PSR-15 middleware
*/
class Middleware implements MiddlewareInterface
{

public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
{
return $handler->handle($request);
}
}
161 changes: 161 additions & 0 deletions tests/Mock/Psr_15/Request.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,161 @@
<?php

namespace Invoker\Test\Mock\Psr_15;

use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\StreamInterface;
use Psr\Http\Message\UriInterface;

class Request implements ServerRequestInterface
{

public function getProtocolVersion()
{

}

public function withProtocolVersion($version)
{

}

public function getHeaders()
{

}

public function hasHeader($name)
{

}

public function getHeader($name)
{

}

public function getHeaderLine($name)
{

}

public function withHeader($name, $value)
{

}

public function withAddedHeader($name, $value)
{

}

public function withoutHeader($name)
{

}

public function getBody()
{

}

public function withBody(StreamInterface $body)
{

}

public function getRequestTarget()
{

}

public function withRequestTarget($requestTarget)
{

}

public function getMethod()
{

}

public function withMethod($method)
{

}

public function getUri()
{

}

public function withUri(UriInterface $uri, $preserveHost = false)
{

}

public function getServerParams()
{

}

public function getCookieParams()
{

}

public function withCookieParams(array $cookies)
{

}

public function getQueryParams()
{

}

public function withQueryParams(array $query)
{

}

public function getUploadedFiles()
{

}

public function withUploadedFiles(array $uploadedFiles)
{

}

public function getParsedBody()
{

}

public function withParsedBody($data)
{

}

public function getAttributes()
{

}

public function getAttribute($name, $default = null)
{

}

public function withAttribute($name, $value)
{

}

public function withoutAttribute($name)
{

}
}
16 changes: 16 additions & 0 deletions tests/Mock/Psr_15/RequestHandler.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php

namespace Invoker\Test\Mock\Psr_15;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface;

class RequestHandler implements RequestHandlerInterface
{

public function handle(ServerRequestInterface $request): ResponseInterface
{
return new Response();
}
}
80 changes: 80 additions & 0 deletions tests/Mock/Psr_15/Response.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
<?php

namespace Invoker\Test\Mock\Psr_15;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\StreamInterface;

class Response implements ResponseInterface
{

public function getProtocolVersion()
{

}

public function withProtocolVersion($version)
{

}

public function getHeaders()
{

}

public function hasHeader($name)
{

}

public function getHeader($name)
{

}

public function getHeaderLine($name)
{

}

public function withHeader($name, $value)
{

}

public function withAddedHeader($name, $value)
{

}

public function withoutHeader($name)
{

}

public function getBody()
{

}

public function withBody(StreamInterface $body)
{

}

public function getStatusCode()
{

}

public function withStatus($code, $reasonPhrase = '')
{

}

public function getReasonPhrase()
{

}
}