Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add petab.v2.C #299

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Add petab.v2.C #299

merged 3 commits into from
Jul 2, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 2, 2024

For now, mostly a copy of v1. The be updated as petab v2 development progresses.

Also adds some missing documentation.

Use of PEtab v2-related constants from petab.v1.C is deprecated.

👀 https://petab--299.org.readthedocs.build/projects/libpetab-python/en/299/build/_autosummary/petab.v2.C.html

For now, just a copy of v1. The be updated as petab v2 progresses.
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 104 lines in your changes missing coverage. Please review.

Project coverage is 72.87%. Comparing base (e4b1861) to head (5e8d7d6).

Files Patch % Lines
petab/v2/C.py 0.00% 104 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #299      +/-   ##
===========================================
- Coverage    74.47%   72.87%   -1.61%     
===========================================
  Files           46       47       +1     
  Lines         4732     4836     +104     
  Branches      1034     1035       +1     
===========================================
  Hits          3524     3524              
- Misses         910     1014     +104     
  Partials       298      298              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl marked this pull request as ready for review July 2, 2024 10:34
@dweindl dweindl requested a review from a team as a code owner July 2, 2024 10:34
@dweindl dweindl requested a review from dilpath July 2, 2024 10:34
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 7fd4498 into PEtab-dev:develop Jul 2, 2024
7 checks passed
@dweindl dweindl deleted the v2_C branch July 2, 2024 11:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants