Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add candidate schema for version 2 #142

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Add candidate schema for version 2 #142

merged 4 commits into from
Jul 5, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 29, 2022

Add candidate schema for PEtab version 2. Choose the appropriate schema for validation. Add information on PEtab extensions to petab.Problem (currently as simple dict as provided in the yaml config).

Does not include required attribute for extensions yet (has to wait for PEtab-dev/PEtab#545).

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #142 (7a978df) into develop (e3a8f82) will decrease coverage by 0.09%.
The diff coverage is 58.33%.

@@             Coverage Diff             @@
##           develop     #142      +/-   ##
===========================================
- Coverage    77.27%   77.18%   -0.10%     
===========================================
  Files           29       29              
  Lines         2579     2586       +7     
  Branches       594      595       +1     
===========================================
+ Hits          1993     1996       +3     
- Misses         430      433       +3     
- Partials       156      157       +1     
Impacted Files Coverage Δ
petab/lint.py 66.86% <0.00%> (-0.40%) ⬇️
petab/yaml.py 87.80% <50.00%> (-2.07%) ⬇️
petab/problem.py 68.37% <80.00%> (+0.12%) ⬆️
petab/C.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3a8f82...7a978df. Read the comment docs.

@dweindl dweindl marked this pull request as ready for review June 26, 2022 16:44
@dweindl dweindl requested a review from FFroehlich June 26, 2022 16:49
@dweindl dweindl merged commit 4cefbc0 into develop Jul 5, 2022
@dweindl dweindl deleted the schema_v2 branch July 5, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants