what is the status of the set timeout issue?

[albjeremias]

Hi
im trying to understand what is going on with docker compose v2 and this library.

You have this notice on the README.md which redirects to a PR that is closed and not solved, but I wonder if this was a docker-compose v1 issue?

During testing we noticed that docker compose seems to send its exit code also commands don't seem to have finished. This doesn't occur for all commands, but for example with stop or down. We had the option to wait for stopped / removed containers using third party libraries but this would make bootstrapping docker-compose much more complicated for the users. So we decided to use a setTimeout(500) workaround. We're aware this is not perfect, but it seems to be the most appropriate solution for now. Details can be found in the #228 (comment) (we're happy to get help here).

[AlexZeitler]

Thanks for asking. The notice in the README deserves an update.

To clarify the history: PR #228 was merged in April 2023. It added support for the docker compose v2 plugin, and the setTimeout(500) workaround came with it. The linked comment describes a problem we saw with docker compose v2.15.1, not with v1: stop returned, but the containers were still reported as running.

We have now tested the current state (v1.5.0, 00c02e7) against Docker Compose v2.27.0 and Docker Engine 29.1.3, with the delay removed:

• stop, stopOne and down: the containers were stopped or removed when the promise resolved, over repeated runs. We could not reproduce the original problem.
• kill: right after the promise resolves, docker inspect reports the container as exited, but the Docker API container list (GET /containers/json, which docker ps uses) still reports it as running for a short moment. So Compose does not return early. The daemon's list lags behind.
• Output: stdout was captured completely without the delay, also for large output.

What we don't know yet is whether the original problem came from Compose v2.15.1 or from the Docker Engine version used back then. This matters for how we remove the delay: If it was Compose, we could keep the delay only for older Compose versions. For that we also need to find the version where the behavior changed.

We'll continue investigating, but it will take some time. We'll post an update here.