Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Transformation algorithm #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nyalldawson
Copy link

Exposes the transformation filter for use by wrench

Copy link
Collaborator

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Would it be possible to also add an example to the README?

I was thinking whether the transformation should not be a part of the translate algorithm - so that potentially one could do multiple operations at once - e.g. move the points in some direction, assign correct CRS and save as LAZ.

(Also, one thing that worries me a bit is that "translate" and "transform" algs may get easily mixed up - at least in my head they do 😄 )

Do we want to also provide command line args for the common operations like translation/scale/rotation, so that people do not need to craft the matrices? or that would be a part of QGIS alg implementation? (e.g. las2las has quite impressive list of various -translate* -scale* -rotate* options)

@hobu
Copy link
Member

hobu commented Jul 11, 2023

Could you add a feature to add a filter block where all of the filters are streamable? You're quickly getting to supporting pipelines, however 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants