Change 'comment=' to 'author=' when comment is just author #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have more to go through, but I'm putting it here just for the time being. |
Mrlinkwii
approved these changes
Jul 16, 2024
TheTechnician27
force-pushed
the
authors
branch
2 times, most recently
from
c5f2bab
to
dbe409d
Compare
TheTechnician27
changed the title
|
I forgot to comment an update that this is ready to be pulled. |
Mrlinkwii
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tons of 'comment=' parameters which would just say e.g. "comment=Widescreen patch by xyz" and nothing else when .pnach has an 'author=' parameter. In addition to making the file less concise, less readable, and less parseable, it also means that the .pnach will show up as "Author: Unknown" followed by a comment about how the author is known within the PCSX2 application.