-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SLES-51194 Pnach #366
Conversation
The fact half of it is commented out because it's broken, but was there because it needed it bothers me. If this patch breaks some of the visuals, I don't really want to supply it with the emulator. |
I haven't had any problems with the game at all, so I've played through several times with the patch and haven't noticed any graphical errors. This patch is also offered here for the Spanish version, so I can't understand why the German version can't be offered for it. Because then you would also have to remove the patch for the Spanish version, because it contains the same code. Edit: I have removed the commented out codes and tested the game again, everything works without any problems. Is that enough for a new verification? |
commented out code has been removed for re-verification.
As long as you're sure the UI stuff is all in the right place, then that's fine. |
the UI all looks stretched, not 16:9 |
Code added and now looks correct with the widescreen patch.
Did you just re-enable the code? cos if it was disabled for reasons then those reasons are probably still a thing. I have to be honest, my confidence in the patch (and your ability to modify it) is slightly worrisome right now. I'm not sure I want to merge this, at least in its current state without extensive testing. |
Yes, I just excluded it, it just says “// Commented out as it broke loading screen font and other stuff.” The only thing I noticed was that nothing is displayed at the beginning when you load a savegame. I had already used this patch several times and had also played like this and so far. I don't know if this problem can be fixed. I can send you a video where I played the game completely and I only noticed this problem. |
I'm sorry, you'll have to get the author to fix it, I can't accept patches which break the graphics in any way. |
All right, no problem. |
There is no Pnach file for SLES-51194 yet and has been added now. The Pnach contains exactly the same as for SLES-51195, as it is identical to the CRC, it is just a different language of the game.