Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formating & Improvements #323

Merged
merged 8 commits into from
May 26, 2024
Merged

Formating & Improvements #323

merged 8 commits into from
May 26, 2024

Conversation

pgert
Copy link
Contributor

@pgert pgert commented Feb 21, 2024

No description provided.

@pgert
Copy link
Contributor Author

pgert commented Feb 22, 2024

The pnachs that I claimed to be made (in part) by nemesis2000 sure looked ported to me (from other regions), but OK.

@PeterDelta
Copy link
Contributor

Have you compared the rest of the Baldurs Gate Non-Interlacing patches to see if there are any improvements over using pcsx2 by default? They seem to do the same thing, I don't have those versions to verify it.

@pgert
Copy link
Contributor Author

pgert commented Feb 22, 2024

No I haven't, and I can't (since I don't own them).
Shall I remove the hacks for those as well (3 pnachs more)?

@PeterDelta
Copy link
Contributor

No I haven't, and I can't (since I don't own them). Shall I remove the hacks for those as well (3 pnachs more)?

I would say yes because those types of patches ruin the game and the image looks like the one I showed in the PAL versions. PCSX2 does a much better job without shaking or anything

@pgert
Copy link
Contributor Author

pgert commented Feb 22, 2024

Done.

@kamfretoz
Copy link
Contributor

What's the status for this PR?

@pgert
Copy link
Contributor Author

pgert commented Mar 3, 2024

It's ready, but someone have to "squash" it for me.

@refractionpcsx2
Copy link
Member

Can you remove the cheats information from the patches, please? Completely irrelevant.

@pgert
Copy link
Contributor Author

pgert commented Mar 17, 2024

Anything else?

@pgert
Copy link
Contributor Author

pgert commented Mar 27, 2024

New WS-hack for the PAL pnachs of Champions of Norrath by PeterDelta.
Tested SLES-52325_75D86958, and can't make out any difference from the old hack by ElHecht.
The hacks by PeterDelta has fever patches (4 instead of 13/14), and consequestly there is no point of combination with 'Widescreen 16:9' for the ported hacks - should be less confusing to end-user.
Added 16:10, 15:10, 20:9 & 21:9 ports.

@refractionpcsx2
Copy link
Member

Would you not rather use the author= parameter instead of putting //pgert in the files? I'm sure that means less to people than having the author.

@pgert
Copy link
Contributor Author

pgert commented Apr 8, 2024

Is this better?

@refractionpcsx2
Copy link
Member

The // removal ones are fine, but why did you change the other ones to have a comment line? Just put both in the author. I had no problem with them

@pgert
Copy link
Contributor Author

pgert commented Apr 10, 2024

I thought it looked better.
Do you insist?

@pgert
Copy link
Contributor Author

pgert commented Apr 16, 2024

Done.

@pgert
Copy link
Contributor Author

pgert commented May 26, 2024

...?

@refractionpcsx2 refractionpcsx2 merged commit 48e672c into PCSX2:main May 26, 2024
3 checks passed
@refractionpcsx2
Copy link
Member

Sorry, forgot about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants