TEST to look at Gh build vs tip #7247
Conversation
Added some logging.
Removed explicit System.exit(0) in Main. It allows to enable "slowtest" that generates and compares XMLs. Marked SystemExitInterceptor as deprecated and removal=true. Since Java does not offer any alternative, we have to find a better solution. P.S. NSIS is planned to be removed to use jpackage only.
…s StackTrace to determine the logger name. This is expensive and replaced with an explicit logger creation.
|
Please wait (as usual, I cannot tell until when) and don't merge this PR |
…methods that return null. In some cases, the null reference/result was not checked, but the code never failed, because it was not executed. There were no tests, that is why it was difficult to check, whether the refactoring was right :(
Update gh_build
1. Corrected the typo in special properties (light crossbow); 2. Corrected maxdex for MAXDEX bonus;
|
Yeah I assume we won't merge this PR, I figured it was just the easiest way to look at a diff and see if we could spot anything. |
# Conflicts: # data/pathfinder/paizo/roleplaying_game/core_rulebook/cr_equip_arms_armor.lst
|
Super interesting those tests fail for you but not for me locally! |
|
If you use your version/branch, but not mine, I bet you have this PR: #6975 |
OK, so just a data fix required then? |
…e the difference between "golden" and generated files). Trimmed lines in base.xml and base-xml.ftl template.
Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
|
Ok, I'd say that we have something, that I can call "release": https://github.com/Vest/pcgen/releases/tag/v0.0.8 Attention: I am not a professional devops. So, I am experimenting with my workflow. Really. So, it can build releases now. I have tested a mac release only. The application starts. It isn't signed, but it can run. My thoughts - delete NSIS completely. But I have to verify windows & linux builds somehow. |
Signed-off-by: Vest <[email protected]>
Is it also possible to create .deb linux distro files? I can test on an Ubuntu system (although it'll be Arm based), I can also test Windows (Arm) but I suspect the exe file is for x86-64? |
|
It is. GitHub makes a number of environments available for performing the build. x86_64 is supported for Windows and Linux, and arm64 for Linux and macOS (not sure about Windows). The Debian (including Ubuntu) and Red Hat (not sure about Fedora) Linux distros are supported. It's not difficult to create a matrix of supported architectures and supported platforms, then let GitHub build ALL OF THEM! Obviously, you'd want to be careful about triggering that one! |
gradle jpackageImage Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
…adlew Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
Added the same task to plugins.gradle Signed-off-by: Vest <[email protected]>
Removed the `buildNsis` task from the Gradle `test_script`, streamlining the build process. Additionally, fixed unnecessary trailing spaces in multiple sections for better formatting consistency. These changes simplify the CI process and improve readability. Signed-off-by: Vest <[email protected]>
This commit deletes `build-gradle.xml` and `pluginbuild.xml` as they are no longer required. The transition to a Gradle-based build system eliminates dependency on Ant, simplifying the build process. Signed-off-by: Vest <[email protected]>
Added a new warning message for remote list preferences in properties. Improved Gradle tasks to include all nested class files for export and bonus plugins, ensuring more comprehensive builds. Signed-off-by: Vest <[email protected]>
…ethod signatures in PCGenTaskExecutor and PluginLoader Signed-off-by: Vest <[email protected]>
…n``` Few recent pull requests broke the styling: PCGen#7319 Signed-off-by: Vest <[email protected]>
…n``` Few recent pull requests broke the styling: PCGen#7319 Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
…lows Signed-off-by: Vest <[email protected]>
# Conflicts: # build.gradle
…n in wrapper scripts Signed-off-by: Vest <[email protected]>
… with new tests Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
…test classes Signed-off-by: Vest <[email protected]>
No description provided.