Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-538: Solved the bug, when PortraitToken path was encoded #6922

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

Vest
Copy link
Contributor

@Vest Vest commented Aug 28, 2023

It breaks the image export. In addition to this change, other changes were added:

  • PortraitTokenTest now uses JUnit5 assertions
  • TestHelper got a helper method "evaluateToken", that was used by other test-classes. This is a small refactoring to avoid the duplicated code;
  • The token object is final;
  • Trimmed spaces in the modified files.

Vest and others added 2 commits August 28, 2023 10:09
… the image export was broken.

PortraitTokenTest now uses JUnit5 assertions
TestHelper got a helper method "evaluateToken", that was used by other test-classes. This is a small refactoring to avoid the duplicated code.

Signed-off-by: Vest <[email protected]>
@Vest
Copy link
Contributor Author

Vest commented Aug 28, 2023

Hello @karianna,
here is the same PR as in #6917, but I have made few changes (because I was moving JUnit4 code to JUnit5) that I have overseen.
In my machine gradle slowtest doesn't fail at all, but you can verify this again.

Please merge the code with the squashed commit. Nobody needs to see my small fault. It doesn't bring any value.

Regarding the changes - I have decided to refactor the code in this PR, because I didn't want to add another duplicate (where I add a code to export tokens into a file), and then refactor the code. The method that I use is required to test a code "if token is encoded write it as encoded, otherwise write it as it is". To check the "encoded" flag, I need: writer and filter. This is the method that was used in other test cases.

@karianna karianna merged commit 2b4d8e4 into PCGen:master Sep 4, 2023
2 checks passed
@Vest Vest deleted the OS-538_2 branch September 6, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants