Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV build setup #209

Merged

Conversation

mykhailodanilenko
Copy link
Contributor

🚀 Description

In this PR the tvOS and Android TV builds are added to the pipeline and the application is adjusted to running on TV. Also, the documents are updated to reflect the necessary steps to buid and edit the TV versions of the app. In https://github.com/mykhailodanilenko/web-client/actions/runs/11729401208 you can see the resulting artifacts, I tested them on all platforms and can confirm the apps are able to build and run. Next step in TV development will be to adjust the app to TV remote navigation.

📄 Motivation and Context

#18 #204

🧪 How Has This Been Tested?

  • Web (desktop)
  • Web (mobile)
  • Mobile (iOS)
  • Mobile (Android)
  • TV (Android)
  • TV (tvOS)

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist (copied from README)

  • Squash your changes into a single clear and thoroughly descriptive commit, split changes into multiple commits only when it contributes to readability
  • Reference the GitHub issue that you are contributing on in your commit title or body
  • Sign your commits, as this is required by the automated GitHub PR checks
  • Ensure that the changes adhere to the project code style and formatting rules by running npx eslint . and npx prettier --check ../ from the ./OwnTube.tv/ directory (without errors/warnings)
  • Include links and illustrations in your pull request to make it easy to review
  • Request a review by @mykhailodanilenko, @ar9708 and @mblomdahl

@mykhailodanilenko mykhailodanilenko added the enhancement New feature or request label Nov 7, 2024
@mykhailodanilenko mykhailodanilenko self-assigned this Nov 7, 2024
@mykhailodanilenko mykhailodanilenko merged commit 1740914 into OwnTube-tv:main Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants