Skip to content

Address click deprecation - use h5netcdf in cli tests #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

Address click deprecation - use h5netcdf in cli tests #2233

merged 2 commits into from
Aug 26, 2025

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Address a Click warning about using Group instead of MultiCommand. I tested and the change is retrocompatible with 8.1 (our lowest click allowed)
  • Use h5netcdf in the cli tests, hopefully that fixes the worker crashes ?

Does this PR introduce a breaking change?

No

Other information:

@aulemahal aulemahal requested a review from Zeitsperre August 26, 2025 12:42
Zeitsperre
Zeitsperre approved these changes Aug 26, 2025
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the approved Approved for additional tests label Aug 26, 2025
@coveralls
Copy link

Coverage Status

coverage: 92.168% (-0.04%) from 92.204%
when pulling f1f3519 on cli-warnings-engine
into ecacf95 on main.

@Zeitsperre Zeitsperre merged commit fa34e1a into main Aug 26, 2025
22 checks passed
@Zeitsperre Zeitsperre deleted the cli-warnings-engine branch August 26, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address Click deprecation warnings
3 participants
@aulemahal @coveralls @Zeitsperre