Handle trailing newline in REDCap checkbox options #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes OuhscBbmc#501 - Modified pattern_checkboxes regular expression to allow for case where there is no space in front of the pipe character in the Lookbehind and Lookahead expressions, and allow the space(s) after the comma to be optional. - Created test case to verify correct handling when a checkbox options has a trailing newline. - Created test case to verify correct handling when the space is missing after the comma for an option.
|
@BlairCooper, I've tagged you about this in two previous issues (#501 & #500). Can you respond to those? |
|
@BlairCooper, sorry I missed your previous response in the other thread. For this PR, the regex isn't working if the id is a negative number. I don't want to discourage you here if you're passionate about continuing a home-grown regex. But I think the two-step approach (of Screenshot of REDCap designer: String for test cases: |
This was referenced Jul 15, 2023
|
@BlairCooper, it sounds like you're ok with the approach of #504, so I'm closing this PR. Please tell me if I'm wrong. I've moved this PR's new scenarios to the list of tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #501
Modified pattern_checkboxes regular expression to allow for case where there is no space in front of the pipe character in the Lookbehind and Lookahead expressions, and allow the space(s) after the comma to be optional.
Created test case to verify correct handling when a checkbox options has a trailing newline.
Created test case to verify correct handling when the space is missing after the comma for an option.