fix: add domain_name to v3.domain_name.fingerprint#126
Closed
burogurama wants to merge 2 commits intomainfrom
Closed
fix: add domain_name to v3.domain_name.fingerprint#126burogurama wants to merge 2 commits intomainfrom
burogurama wants to merge 2 commits intomainfrom
Conversation
burogurama
requested review from
1l0c,
3asm,
Ayman-ANNA,
HamzaElyoussfi,
Lachhab26,
Moonflower1911,
MouadAO,
Nouri-Anouar,
Oussama-Bakri,
Zakaria-Latif,
amat-osto,
amine3,
azizelbelaychy,
m0hamed-ait,
m0hamed541,
marouaneabeqqal-ostorlab,
mouadostor,
ohachimOs,
sohaibharraoui,
yami-ost,
yasser-abassi,
yassminassaii and
zoulatizakaria
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 94.24% 94.25% +0.01%
==========================================
Files 11 11
Lines 1077 1080 +3
==========================================
+ Hits 1015 1018 +3
Misses 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amat-osto
approved these changes
Feb 23, 2026
3asm
requested changes
Feb 23, 2026
Comment on lines
+385
to
+386
| data = dict(fingerprint) | ||
| data["domain_name"] = domain_name |
Member
Author
There was a problem hiding this comment.
port was already part of the message. I just added domain_name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add domain_name to emitted v3.domain_name.fingerprint messages