-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve api pr checklist #309
Conversation
Update the api pr checklist pre-requisites to fix the links to other documents Add checklist items for unit testing, updating .env.example values Add a note for reviewers to follow when reviewing and merging PR
WalkthroughThe primary change in this pull request template focuses on enhancing the clarity and structure of the checklist items for API documentation. Revisions aim to improve the communication of testing and documentation requirements, ensuring contributors understand necessary steps before submission. Adjustments include rephrased items highlighting unit testing and the inclusion of an Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/PULL_REQUEST_TEMPLATE/pull_request_template_api.md (4 hunks)
Files skipped from review due to trivial changes (1)
- .github/PULL_REQUEST_TEMPLATE/pull_request_template_api.md
API PR Checklist
Pre-requisites
.env.example
file with the required values as applicable.PR Details
PR details have been updated as per the given format (see below)
feat: add admin login endpoint
)Additional Information
ready for review
should be added if the PR is ready to be reviewed)Note: Reviewer should ensure that the checklist and description have been populated and followed correctly, and the PR should be merged only after resolving all conversations and verifying that CI checks pass.
Description:
This PR updates the the API PR Checklist (as used above) by adding some additional checks and information for more comprehensive checks when creating a PR to promote consistency and avoid unforeseen issues.
Related changes:
Screenshots:
N/A
Query request and response:
N/A
Documentation changes:
N/A
Test suite/unit testing output:
N/A
Pending actions:
N/A
Additional notes:
N/A
Summary by CodeRabbit
.env.example
file.