feat: add display mappings for delivery status and channel type #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add deliveryStatusMap and channelTypeMap for mapping display strings for corresponding values Update notifications.component html to use these maps when displaying delivery status and channel type values
ghost
self-assigned this
xixas
requested changes
Jan 16, 2024
There was a problem hiding this comment.
@LakshayaT
Add teplate formatting to status for example status field here.
https://primeng.org/table#template
https://www.primefaces.org/primeng-v14-lts/table/templating
Update notifications.scss to add styles for displaying statuses as badges Update notifcations.component ts file to add style string to the deliveryStatusMap Update notifications.component html file to properly display status strings using style and value strings
This has been implemented in c12d32a. |
xixas
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds display string mappings for showing easily readable strings for Channel Type and Delivery Status in the portal instead of numeric values.
Related changes:
Screenshots:
