feat: add toastr service #23
Conversation
WalkthroughThe update introduces enhancements to the Angular project by integrating the Toastr notification library, adding its CSS to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (4)
- angular.json (3 hunks)
- package.json (3 hunks)
- src/app/shared/services/toastr.service.ts (1 hunks)
- tsconfig.json (1 hunks)
Additional comments not posted (11)
tsconfig.json (1)
9-9: LGTM!The addition of
"allowSyntheticDefaultImports": trueis a good enhancement for compatibility with various JavaScript modules and libraries.The code changes are approved.
src/app/shared/services/toastr.service.ts (5)
9-17: LGTM!The constructor correctly initializes the toastr options. Consider adding comments to explain the configuration options if needed.
The code changes are approved.
19-21: LGTM!The
successmethod correctly displays a success message using toastr.The code changes are approved.
23-25: LGTM!The
errormethod correctly displays an error message using toastr.The code changes are approved.
27-29: LGTM!The
infomethod correctly displays an info message using toastr.The code changes are approved.
31-33: LGTM!The
warningmethod correctly displays a warning message using toastr.The code changes are approved.
package.json (2)
34-34: LGTM!The addition of
toastras a dependency is appropriate for the toastr service.The code changes are approved.
49-49: LGTM!The addition of
@types/toastras a dependency is appropriate for TypeScript type definitions.The code changes are approved.
angular.json (3)
30-30: LGTM!The addition of the Toastr CSS file to the styles array is appropriate and necessary for styling the Toastr notifications.
The code changes are approved.
90-90: LGTM!The addition of the Toastr CSS file to the styles array in the test options is appropriate and necessary for styling the Toastr notifications during testing.
The code changes are approved.
106-107: LGTM!The addition of the
analyticsproperty with a unique identifier in the CLI settings is appropriate for tracking and analytics purposes.The code changes are approved.
package.json
Outdated
| @@ -31,6 +31,7 @@ | |||
| "primeicons": "^6.0.1", | |||
| "primeng": "^16.7.2", | |||
| "rxjs": "~7.8.0", | |||
| "toastr": "^2.1.4", | |||
There was a problem hiding this comment.
Any reason why we are using this?
We have created this foundation using primeNG. So we should be using toast from primeNG too?
There was a problem hiding this comment.
i took the toastr service from pickleball initial setup as suggested by Raj, there we were using toastr, also I don't see any primeng module imported in foundation right now, should I go ahead an add primeng.module.ts and use primeng toastr instead of this?
There was a problem hiding this comment.
Yes use primeng toastrs only. For Foundation we will rely on PrimeNG only
https://primeng.org/toast
package.json
Outdated
| @@ -31,6 +31,7 @@ | |||
| "primeicons": "^6.0.1", | |||
| "primeng": "^16.7.2", | |||
| "rxjs": "~7.8.0", | |||
| "toastr": "^2.1.4", | |||
There was a problem hiding this comment.
Yes use primeng toastrs only. For Foundation we will rely on PrimeNG only
https://primeng.org/toast
Changes in PR:
Summary by CodeRabbit
New Features
ToastrServicefor easy integration of notifications throughout the application.Enhancements
Dependencies
toastrand its type definitions for notification support.