Skip to content

telemetry with batching, persistence, and improved logging #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v8/develop
Choose a base branch
from
Open

telemetry with batching, persistence, and improved logging #4014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
553e619
telemetry with batching, persistence, and improved logging
Niks988 Jul 25, 2025
ed00978
improved proof logging, other improvements
Niks988 Jul 28, 2025
51d3ce4
improved proof logging, other improvements
Niks988 Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ot-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,18 @@ class OTNode {

async handleExit() {
this.logger.info('SIGINT or SIGTERM received. Shutting down...');

// Cleanup telemetry first to ensure all events are sent
try {
const telemetryModuleManager = this.container.resolve('telemetryModuleManager');
if (telemetryModuleManager && telemetryModuleManager.getImplementation()) {
this.logger.info('Cleaning up telemetry...');
await telemetryModuleManager.getImplementation().module.cleanup();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Telemetry Cleanup Method Access Error

The telemetry cleanup call in handleExit incorrectly attempts to access telemetryModuleManager.getImplementation().module.cleanup(). The cleanup() method is directly available on the object returned by getImplementation(), not nested under a .module property, which will cause a runtime error.

Locations (1)

Fix in Cursor Fix in Web

}
} catch (error) {
this.logger.error(`Error during telemetry cleanup: ${error.message}`);
}

const commandExecutor = this.container.resolve('commandExecutor');
await commandExecutor.commandExecutorShutdown();
process.exit(0);
Expand Down
Loading
Loading