Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Upgrade to Sanity V3 #165

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

magnusgiverin
Copy link
Collaborator

OBS OBS VÆR EKSTREMT SKEPTISK

@magnusgiverin magnusgiverin added the enhancement New feature or request label Oct 23, 2023
@magnusgiverin magnusgiverin self-assigned this Oct 23, 2023
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for keen-davinci-769980 canceled.

Name Link
🔨 Latest commit dbfa65a
🔍 Latest deploy log https://app.netlify.com/sites/keen-davinci-769980/deploys/653a35a89508850008202ab1

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for verdant-souffle-6c4e17 failed.

Name Link
🔨 Latest commit dbfa65a
🔍 Latest deploy log https://app.netlify.com/sites/verdant-souffle-6c4e17/deploys/653a35a8eeb13c0008a8dcb8

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for romantic-ride-755295 failed.

Name Link
🔨 Latest commit dbfa65a
🔍 Latest deploy log https://app.netlify.com/sites/romantic-ride-755295/deploys/653a35a82818e90008da1b03

Copy link
Contributor

@isaksolheim isaksolheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki I have some things I noticed! But super nice that we have somebody working on this now 🎆

U have added new dependencies at root in the project, when this repo is split into two separate project (/sanity) and (/frontend), so everything sanity related should be done in /sanity.

the .sanity folder should be added to the .gitignore

also seems like someone once used yarn at root in the project, the yarn.lock there can just be removed

Copy link
Contributor

@isaksolheim isaksolheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.sanity is still checked in, and even more packages was added to package.json 😬 this can all be removed

Copy link
Contributor

@isaksolheim isaksolheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm there is still a very huge diff on the package-lock.json file in the root of the project, did u remember to run npm i after removing the dependencies from package.json? 🤔

@isaksolheim
Copy link
Contributor

but other than that I think ur good! but you should check the logs from netlify and try to figure out why everything is red 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants