Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted screensaver.js bug fixes. #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gollimnar
Copy link

As mentioned in #171 -

Setting video.src = "" or video.src = null causes an error event, at least in the edge engine (chromium?). Setting it to video.removeAttribute( "src" ) has the correct result.

The error events in "pre-player" would fail to log the reason for the error properly.

prepVideo() didn't handle failure to find the video by ID properly - the workaround just logs this and lets it skip to another video instead of a dereferencing a null value.

The fade/down and wipe/down transitions should have read 'bottom' instead to match the transition code. They triggered a null dereference exception as a result.

Any errors inside drawVideo() - like transitions - result in drawVideo() not being queued up again for the next animation frame, freezing the screensaver.

The 'blankTheScreen' message repeats and would cause a slow strobe effect as the fadeout effect would trigger each time.


Note that two outstanding screensaver bugs still seem to exist and aren't fixed by this. In each case they were only observed once and I couldn't duplicate them:

  • An unknown error that was probably caused by the prepVideo() issue.
  • An error during fadeout that causes it to terminate with the video showing instead of a blank screen at the end of the effect.

Leaving the screensaver running for extended periods, I can no longer trigger any further bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant