Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#85] Rename demo app (and any references) to Design System Toolbox #399

Merged
merged 30 commits into from
Jan 21, 2025

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Jan 20, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#85

Description

  • When needed, apply long name "Drsign System Toolbox"
  • When needed, apply short name "DesignToolbox"
  • Change CI/CD scripts, data types, docs, tests plans, schemes, targets...

Motivation & Context

  • Apply the enw name we got from the Brand about this demo app

Types of change

  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@pylapp pylapp requested a review from ludovic35 as a code owner January 20, 2025 12:42
@pylapp pylapp linked an issue Jan 20, 2025 that may be closed by this pull request
@pylapp
Copy link
Member Author

pylapp commented Jan 20, 2025

@ludovic35 Commit message must be:

refactor: apply new name to demo app (`design system toolbox`) (#85) (#399)

@pylapp
Copy link
Member Author

pylapp commented Jan 20, 2025

WARNING: The GitLab CI must be updated soon after the merge with updated script

pylapp added 24 commits January 21, 2025 09:40
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp force-pushed the 85-demo-app-renaming-of-demo-application branch from d1a9a5e to 162086c Compare January 21, 2025 10:14
@pylapp pylapp merged commit 7fe5b61 into develop Jan 21, 2025
7 of 8 checks passed
@pylapp pylapp deleted the 85-demo-app-renaming-of-demo-application branch January 21, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Demo App] Renaming of demo application
2 participants