Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#85] [#140] [#141] Improve demo app distribution #142

Closed
wants to merge 1 commit into from
Closed

[#85] [#140] [#141] Improve demo app distribution #142

wants to merge 1 commit into from

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Oct 1, 2024 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#85
#140
#141

Description

  • Rename the demo app (in both TestFlight and CI/CD chain)
  • Add icons for alpha, beta and production builds
  • Split builds by changing bundle identifiers (alpha, beta and prod)

Motivation & Context

  • Allows testers to have in the same devices the alpha, the beta and the prod apps
  • Make them able to find them easily
  • Use a name validated by the Brand department

Types of change

  • Refactoring (non-breaking change)

Previews

None

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • (NA) I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@pylapp
chore: update CHANGELOG (#85,#140,#141)
ae62e01 
Closes #85
Closes #140
Closes #141

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp self-assigned this Oct 1, 2024
@pylapp pylapp linked an issue Oct 1, 2024 that may be closed by this pull request
[Demo App] Renaming of demo application #85
Open
@pylapp pylapp marked this pull request as draft October 1, 2024 13:47
This was linked to issues Oct 1, 2024
[Demo App] Update the app icon with the new launch icon #140
Closed
[Tooling] [CI/CD] Create a separate alpha release version #141
Open
@pylapp pylapp force-pushed the develop branch 3 times, most recently from 547eb36 to d68fddd Compare October 24, 2024 08:29
@pylapp pylapp removed their assignment Oct 24, 2024
@pylapp pylapp force-pushed the develop branch 7 times, most recently from b0984f3 to b6f3503 Compare November 13, 2024 11:35
@pylapp pylapp closed this Nov 18, 2024
This was unlinked from issues Nov 27, 2024
[Demo App] Renaming of demo application #85
Open
[Demo App] Update the app icon with the new launch icon #140
Closed
[Tooling] [CI/CD] Create a separate alpha release version #141
Open
@pylapp pylapp deleted the 85-140-141-improve-demo-app-distribution branch November 28, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovic35 ludovic35 Awaiting requested review from ludovic35 ludovic35 is a code owner

@Tayebsed93 Tayebsed93 Awaiting requested review from Tayebsed93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pylapp