Skip to content

Commit

Permalink
refactor: update short (bundle display) and long (produc) names (#85)
Browse files Browse the repository at this point in the history
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
  • Loading branch information
pylapp committed Jan 20, 2025
1 parent 540bb3f commit 8046255
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions DesignToolbox/DesignToolbox.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1382,7 +1382,7 @@
ENABLE_PREVIEWS = YES;
GENERATE_INFOPLIST_FILE = NO;
INFOPLIST_FILE = DesignToolbox/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = "Design System Toolbox (DEBUG)";
INFOPLIST_KEY_CFBundleDisplayName = "DesignToolbox (DEBUG)";
INFOPLIST_KEY_UIApplicationSceneManifest_Generation = YES;
INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents = YES;
INFOPLIST_KEY_UILaunchScreen_Generation = YES;
Expand Down Expand Up @@ -1421,7 +1421,7 @@
ENABLE_PREVIEWS = YES;
GENERATE_INFOPLIST_FILE = NO;
INFOPLIST_FILE = DesignToolbox/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = "Design System Toolbox (DEBUG)";
INFOPLIST_KEY_CFBundleDisplayName = "DesignToolbox (DEBUG)";
INFOPLIST_KEY_UIApplicationSceneManifest_Generation = YES;
INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents = YES;
INFOPLIST_KEY_UILaunchScreen_Generation = YES;
Expand Down
2 changes: 1 addition & 1 deletion DesignToolbox/DesignToolbox/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<key>CFBundleDevelopmentRegion</key>
<string>$(DEVELOPMENT_LANGUAGE)</string>
<key>CFBundleDisplayName</key>
<string>Design System Toolbox (DEBUG)</string>
<string>DesignToolbox (DEBUG)</string>
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
Expand Down
6 changes: 3 additions & 3 deletions DesignToolbox/fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ platform :ios do

# CFBundleVersion and CFBundleShortVersionString must follow rules with integers and periods, should not change them
# But still possible to change CFBundleDisplayName
new_display_name = "Design System Toolbox ALPHA (#{issues_numbers})"
new_display_name = "DesignToolbox (ALPHA) (#{issues_numbers})"
puts "ℹ️ New display name version will be: '#{new_display_name}'"
set_info_plist_value(path: "#{Dir.pwd}/../DesignToolbox/Info.plist", key: "CFBundleDisplayName", value: new_display_name)

Expand All @@ -241,7 +241,7 @@ platform :ios do
sh "cp -R AppIconBeta.appiconset AppIconRelease.appiconset"
end

new_display_name = "Design System Toolbox (BETA)"
new_display_name = "DesignToolbox (BETA)"
puts "ℹ️ New display name version will be: '#{new_display_name}'"
set_info_plist_value(path: "#{Dir.pwd}/../DesignToolbox/Info.plist", key: "CFBundleDisplayName", value: new_display_name)

Expand All @@ -260,7 +260,7 @@ platform :ios do
puts "👉 Prod"
update_build_number

new_display_name = "Design System Toolbox"
new_display_name = "DesignToolbox"
puts "ℹ️ New display name version will be: '#{new_display_name}'"
set_info_plist_value(path: "#{Dir.pwd}/../DesignToolbox/Info.plist", key: "CFBundleDisplayName", value: new_display_name)

Expand Down

0 comments on commit 8046255

Please sign in to comment.