OK-508: Hakujen sivutus selaimessa #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sivutuksen resetointi muutettaessa hakuparametreja
…iin ja lisätty sivun koon asettaminen
pretseli
force-pushed
the
OK-508_hakujen-sivutus-selaimessa
branch
2 times, most recently
from
6a85836 to
1edee12
Compare
…aikana, eikä käännösaikana.
…-parametreille ja sorttaukselle
…aan ja menetetä kursorin sijaintia
…yyppitarkistuksen
pretseli
force-pushed
the
OK-508_hakujen-sivutus-selaimessa
branch
from
4427f2a to
81a3d6d
Compare
src/app/hooks/useHakuSearch.tsx
Outdated
| DEFAULT_NUQS_OPTIONS, | ||
| ); | ||
|
|
||
| const setSearchDebounce = useDebounce(setSearchPhrase, 500); |
There was a problem hiding this comment.
Pitäisköhän tuo 500 olla jokin constant? voitais varmaan tehdä se constants.ts filu
src/app/lib/common.ts
Outdated
| }; | ||
| }; | ||
|
|
||
| export const PAGE_SIZES = [10, 20, 30, 50, 100]; |
There was a problem hiding this comment.
Olisko näille sopivampi paikka constants.ts?
src/app/lib/common.ts
Outdated
| ); | ||
| } | ||
|
|
||
| export const byProp = < |
There was a problem hiding this comment.
Mietin onko tämä turhan specifiä commoniin? Table-utils?
- Ladataan hakutavat vasta HakutapaSelect-komponentin rendauksen yhteydessä ja näytetään spinneri kun hakutapoja ladataan
pretseli
force-pushed
the
OK-508_hakujen-sivutus-selaimessa
branch
from
8b95650 to
7e21e2e
Compare
SalamaGofore
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oletko lisännyt tarvittavat yksikkö- tai ui-testit toiminnallisuudelle? Kyllä
Oletko tarkistanut ja päivittänyt riippuvuudet? En
Oletko kokeillut toimiiko käyttöliittymä mobiilissa landscape moodissa? En