Hle 1387 hakukohderyhmapalvelu tuki new #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msiukola
reviewed
Oct 14, 2021
Comment on lines
245
to
246
| CompletableFuture<ResultSearch> tarjontaF = this.findTarjontaHakukohteetForHaku(hakuOid); | ||
| CompletableFuture<Set<KoutaHakukohde>> koutaF = this.findKoutaHakukohteetForHaku(hakuOid); |
There was a problem hiding this comment.
Tähän malliin on tehty muuallakin asioita tähän asti, mutta nyt hiljattain on mietitty että olisi parempi jos pääteltäisiin oidin pituudesta että onko tieto vanhassa Tarjonnassa vai Koutassa ja jätettäisiin sitten se tarpeeton kutsu tekemättä. Kouta-hakujen oidit ovat tämän pituisia: "1.2.246.562.29.00000000000000000800", mun käsittääkseni voi olettaa että ne tulevat olemaan sitä jatkossakin. Vanhan tarjonnan oidit ovat lyhyempiä.
augustk
force-pushed
the
HLE-1387_hakukohderyhmapalvelu_tuki_new
branch
from
1ed3c6d to
f6ff434
Compare
augustk
force-pushed
the
HLE-1387_hakukohderyhmapalvelu_tuki_new
branch
from
f6ff434 to
d94cd81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tehty uusi versio pullarista: #101