SHARED:AKR:OTR:VKT:YKI(Frontend): Fix native select component [deploy]

Opetushallitus · Oct 7, 2024 · 9a15041 · 9a15041
1 parent edf928b
commit 9a15041
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 12 deletions.
diff --git a/frontend/packages/akr/package.json b/frontend/packages/akr/package.json
@@ -22,6 +22,6 @@
     "akr:tslint": "yarn g:tsc --pretty --noEmit"
   },
   "dependencies": {
-    "shared": "npm:@opetushallitus/[email protected].3"
+    "shared": "npm:@opetushallitus/[email protected].4"
   }
 }
diff --git a/frontend/packages/otr/package.json b/frontend/packages/otr/package.json
@@ -25,6 +25,6 @@
     "otr:tslint": "yarn g:tsc --pretty --noEmit"
   },
   "dependencies": {
-    "shared": "npm:@opetushallitus/[email protected].3"
+    "shared": "npm:@opetushallitus/[email protected].4"
   }
 }
diff --git a/frontend/packages/shared/CHANGELOG.MD b/frontend/packages/shared/CHANGELOG.MD
@@ -9,6 +9,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Released]
 
+## [1.11.4] - 2024-10-07
+
+### Fixed
+- Fixed bug introduced in v.1.11.1: NativeSelect and NativeSelectWithLabel didn't display chosen value correctly
+
 ## [1.11.3] - 2024-09-18
 
 ### Added

diff --git a/frontend/packages/shared/package.json b/frontend/packages/shared/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@opetushallitus/kieli-ja-kaantajatutkinnot.shared",
-  "version": "1.11.3",
+  "version": "1.11.4",
   "description": "Shared Frontend Package",
   "exports": {
     "./components": "./src/components/index.tsx",

diff --git a/frontend/packages/shared/src/components/NativeSelect/NativeSelect.tsx b/frontend/packages/shared/src/components/NativeSelect/NativeSelect.tsx
@@ -11,7 +11,7 @@ import { ComboBoxOption } from '../../interfaces';
 import { Text } from '../Text/Text';
 
 export interface CustomNativeSelectProps
-  extends BaseSelectProps<ComboBoxOption> {
+  extends Omit<BaseSelectProps<string>, 'value'> {
   'data-testid'?: string;
   helperText?: string;
   showError?: boolean;
@@ -27,7 +27,7 @@ const CustomSelect = ({
   ...rest
 }: CustomNativeSelectProps) => {
   const options = [{ label: placeholder, value: '' }, ...values];
-  const inputValue = value && value.value ? value : '';
+  const inputValue = value && value.value ? value.value : '';
 
   return (
     <Select variant={Variant.Outlined} value={inputValue} {...rest} native>

diff --git a/frontend/packages/vkt/package.json b/frontend/packages/vkt/package.json
@@ -26,6 +26,6 @@
   },
   "dependencies": {
     "reduxjs-toolkit-persist": "^7.2.1",
-    "shared": "npm:@opetushallitus/[email protected].3"
+    "shared": "npm:@opetushallitus/[email protected].4"
   }
 }
diff --git a/frontend/packages/yki/package.json b/frontend/packages/yki/package.json
@@ -26,7 +26,7 @@
     "yki:tslint": "yarn g:tsc --pretty --noEmit"
   },
   "dependencies": {
-    "shared": "npm:@opetushallitus/[email protected].3"
+    "shared": "npm:@opetushallitus/[email protected].4"
   },
   "devDependencies": {
     "multer": "^1.4.5-lts.1"

diff --git a/frontend/yarn.lock b/frontend/yarn.lock
@@ -2588,15 +2588,15 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@opetushallitus/kieli-ja-kaantajatutkinnot.akr@workspace:packages/akr"
   dependencies:
-    shared: "npm:@opetushallitus/[email protected].3"
+    shared: "npm:@opetushallitus/[email protected].4"
   languageName: unknown
   linkType: soft
 
 "@opetushallitus/kieli-ja-kaantajatutkinnot.otr@workspace:packages/otr":
   version: 0.0.0-use.local
   resolution: "@opetushallitus/kieli-ja-kaantajatutkinnot.otr@workspace:packages/otr"
   dependencies:
-    shared: "npm:@opetushallitus/[email protected].3"
+    shared: "npm:@opetushallitus/[email protected].4"
   languageName: unknown
   linkType: soft
 
@@ -2689,7 +2689,7 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@opetushallitus/kieli-ja-kaantajatutkinnot.shared@workspace:packages/shared, shared@npm:@opetushallitus/[email protected].3":
+"@opetushallitus/kieli-ja-kaantajatutkinnot.shared@workspace:packages/shared, shared@npm:@opetushallitus/[email protected].4":
   version: 0.0.0-use.local
   resolution: "@opetushallitus/kieli-ja-kaantajatutkinnot.shared@workspace:packages/shared"
   languageName: unknown
@@ -2700,7 +2700,7 @@ __metadata:
   resolution: "@opetushallitus/kieli-ja-kaantajatutkinnot.vkt@workspace:packages/vkt"
   dependencies:
     reduxjs-toolkit-persist: "npm:^7.2.1"
-    shared: "npm:@opetushallitus/[email protected].3"
+    shared: "npm:@opetushallitus/[email protected].4"
   languageName: unknown
   linkType: soft
 
@@ -2709,7 +2709,7 @@ __metadata:
   resolution: "@opetushallitus/kieli-ja-kaantajatutkinnot.yki@workspace:packages/yki"
   dependencies:
     multer: "npm:^1.4.5-lts.1"
-    shared: "npm:@opetushallitus/[email protected].3"
+    shared: "npm:@opetushallitus/[email protected].4"
   languageName: unknown
   linkType: soft