OK-770 attachment deadline logic for kk application payments #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaeinoe
commented
Dec 18, 2024
Comment on lines
+578
to
+579
| :hakuajat [{:alkaa "2030-01-01T08:00:00", | ||
| :paattyy "2030-06-01T15:00:00"}]}) |
There was a problem hiding this comment.
Tätä käyttävät testit tulevat toimimaan ongelmitta seuraavat 5 vuotta: toivottavasti sillä välillä ataruun tehdään isompi remppa, eivätkä jälkipolvet joudu lisäämään tähän taas viittä tai kymmentä vuotta.
vaeinoe
commented
Dec 18, 2024
| @@ -23,6 +23,23 @@ | |||
| (def kk-application-payment-document-exempt-options | |||
| (dissoc kk-application-payment-document-options :no-document-option-value)) | |||
|
|
|||
| (def kk-application-payment-exempt-attachment-keys | |||
There was a problem hiding this comment.
Tästä puuttuu siis modulin liitteistä none-passport-attachment tarkoituksella, koska se ei kuulu vapauttavaan kysymykseen.
vaeinoe
force-pushed
the
OK-770-kk-payment-attachment-deadline-logic
branch
from
ce2ba3f to
5e0de7d
Compare
hajoa
approved these changes
Dec 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when the exemption question is answered, making the applicant exempt from application payment, the required attachment must still be present and valid by the attachment deadline.
If one or more of the mandatory attachments in the module is marked incomplete or missing, and the attachment deadline for the admission has already passed, set payment required for the person.