Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted all the css into Tailwind css of Container component #1746

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

Converted all the css into Tailwind css of Container component #1746

wants to merge 47 commits into from
+27 −75

Conversation

subhajit20
Copy link
Contributor

Description of changes

Converted all the css into Tailwind css of Container component
Issue - #1725

Issue Resolved

Fixes #NA

Screenshots/GIFs

subhajit20 and others added 30 commits September 18, 2023 06:12
@subhajit20
Converted all the css to tailwind css of ErrorDisplay page
42bf6db
@subhajit20
Converted all the css to tailwind css of ErrorDisplay page
827b21d
@subhajit20
Converted all css to tailwind css
dc7b10e
@subhajit20
Replace all styling with Tailwind
23a6499
@subhajit20
Replace all styling with Tailwind
1055b07
@subhajit20
Converted all the css into tailwind css of Badge component
1299eac
@subhajit20
Merge branch 'main' into subhajit20/Replace-all-styling-with-Tailwind
71a9b5c
@subhajit20
Converted all the css into Tailwind css of Badge component
46f136d
@subhajit20
Merge branch 'main' into subhajit20/Replace-all-styling-with-Tailwind
be04445
@subhajit20 @kylemh
Update components/Badge/Badge.js
7462502 
Co-authored-by: Kyle Holmberg <[email protected]>
@subhajit20
Fixed syntax error
e67dbca
@kylemh
Merge remote-tracking branch 'origin/main' into subhajit20/Replace-al…
b7ec44a 
…l-styling-with-Tailwind
@kylemh
resolve styling problems
d371d87
@subhajit20
Convert all the css into tailwind css of SocialMedia component
44f4e1b
@subhajit20
Convert all the css into tailwind css of SocialMedia component
1339530
@subhajit20
Merge branch 'main' into subhajit20/Replace-all-styling-with-Tailwind
96d04fc
@subhajit20 @kylemh
Update components/SocialMedia/SocialMediaItem/SocialMediaItem.js
116d86b 
Co-authored-by: Kyle Holmberg <[email protected]>
@subhajit20
Convert all the css into tailwind css of SocialMedia component
0e2a6d0
@subhajit20
Converted all the css into tailwind css of Modal component
b59594e
@subhajit20
Merge branch 'main' into subhajit20/Replace-all-styling-with-Tailwind
c377581
@subhajit20
Converted all the css into tailwind css of Modal compononent
71dbf56
@subhajit20
Converted all the css into tailwind css of Modal compononent
db5f1b7
@subhajit20
Converted all the css into tailwind css of Modal compononent
cd9ceca
@kylemh
remove dumb lint rule
ed3a348
@kylemh
integrate tailwind into Storybook
310f33d
@kylemh
update modal API and fix issue where modal would not render
75d204b
@kylemh
update snapshot tests
b518d21
@subhajit20
Converted all the css to into tailwind css of HeroBanner page
123b778
@kylemh
Merge branch 'main' into subhajit20/Replace-all-styling-with-Tailwind
ce6ffa4
@kylemh
add ability to use text-shadwo
404c13b
@subhajit20 subhajit20 requested a review from kylemh October 9, 2023 07:00
@subhajit20
Copy link
Contributor Author

hey @kylemh any further changes needed?

@kylemh
Copy link
Member

kylemh commented Oct 11, 2023

Yes. If you look into the status checks of this PR, you'll see that tests are failing. You'll want to fix those failures.

Additionally, you should do some due dilligence by running the dev server and comparing betwen production and your local branch. I see that background color is incorrect on https://operation-code-r4usxeoc6-operation-code.vercel.app/#join-our-thriving-community-link (see baseline). Also note that the About page's hero's background image is out of position when compared to prod.

These are just two of potentially multiple issues that you'll want to investigate and resolve.

@subhajit20
Copy link
Contributor Author

Yes. If you look into the status checks of this PR, you'll see that tests are failing. You'll want to fix those failures.

Additionally, you should do some due dilligence by running the dev server and comparing betwen production and your local branch. I see that background color is incorrect on https://operation-code-r4usxeoc6-operation-code.vercel.app/#join-our-thriving-community-link (see baseline). Also note that the About page's hero's background image is out of position when compared to prod.

These are just two of potentially multiple issues that you'll want to investigate and resolve.

Okay will check that

@kylemh kylemh mentioned this pull request Oct 22, 2023
Open
@subhajit20
Copy link
Contributor Author

hey @kylemh sorry for the delay,
I am a bit confused, can you help out?

@kylemh
Copy link
Member

kylemh commented Oct 30, 2023

Not for awhile, but maybe you can pause here and try converting another component? Please share which component you plan on doing in #1725 before doing it so you dont step on somebody else's feet!

@subhajit20 subhajit20 mentioned this pull request Oct 31, 2023
Merged
@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 14, 2023

Code Climate has analyzed commit 4c30d24 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 75.6% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylemh kylemh Awaiting requested review from kylemh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subhajit20 @kylemh