fix(motor-control): improve stop request handling #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So when a stop request is broadcast it was previously sending out 2-3 responses per motor axis. 1 from the move group controller, 1 from the motor controller and 1 from the motor interrupt handler if the motor has been previously enabled (which is always true except right after a firmware update or power cycle.)
This PR removes the response from the move group controller, since this message always responded with a message index 0 which is unhelpful and will reduce the number of messages by 1/3 and prevents many of the "Error 1008 CAN_BUS_ERROR: error frame encountered" instances