Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hepa-uv): Add external IRQ handling and HEPA fan task to drive the HEPA fan. #742

Merged
merged 12 commits into from
Jan 18, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Jan 17, 2024

Overview

Continue to add functionality to the HEPA/UV project, this change mainly adds the HEPA task to handle push button irq to turn the HEPA fan on/off.

Closes: RET-1399 RET-1400 RET-1401

Changes

  • Added GPIO EXTI interrupt configuration
  • Added irq router for door_open, reed_switch, hepa_push_button, and uv_push_button
  • Added HepaTask that is responsible for handling irq events received on its message queue to turn the HEPA fan on/off
  • Fixed up GPIO init configuration for door_open, reed_switch, and others

Todo

  • Should I add PWM controls to turn on the HEPA/Fan here, or can I add a separate PR?

…uv_push_button

- Added HepaTask that is responsible for handeling irq events received on its message queue to turn the hepa fan on/off
- Fixed up gpio init settings for door_open, reed_switch and others
@vegano1 vegano1 requested a review from sfoster1 January 17, 2024 17:07
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vegano1
Copy link
Contributor Author

vegano1 commented Jan 18, 2024

Will fix simulator later on RET-1408

@vegano1 vegano1 merged commit 05f9090 into main Jan 18, 2024
16 of 20 checks passed
@vegano1 vegano1 deleted the RET-1400_route_irq_to_queue branch January 18, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants