Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(state-manager): update state manager python version & update dependencies #739

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

ahiuchingau
Copy link
Contributor

@ahiuchingau ahiuchingau commented Jan 5, 2024

Our OT3 is running on Python 3.10 now, this means the state manager environment should also reflect that.

Changelog

  • add main-setup Github action that installs the required version of gcc and python for reusability
  • replace old workflows with:
    • cross-compile-all: build/format/lint all firwmare executable targets in parallel
    • build-simulators: build simulators for targets and upload them as artifacts
    • build-tests: build-and-test

This hopefully makes it easier for us to add firmware targets/update dependencies in the future.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice ty

@ahiuchingau ahiuchingau force-pushed the chore_update-python-version branch 2 times, most recently from f576d54 to 99a6b9b Compare January 10, 2024 03:31
@ahiuchingau ahiuchingau changed the base branch from main to chore_fix-boost January 10, 2024 03:31
Base automatically changed from chore_fix-boost to main January 10, 2024 15:27
@ahiuchingau ahiuchingau force-pushed the chore_update-python-version branch from 2e2e0fd to 0147093 Compare January 17, 2024 23:05
@ahiuchingau ahiuchingau force-pushed the chore_update-python-version branch from df13a7e to a5e150a Compare January 18, 2024 21:43
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de895f8) 84.30% compared to head (8ae1ff2) 83.71%.
Report is 48 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   84.30%   83.71%   -0.60%     
==========================================
  Files          87      101      +14     
  Lines        3836     4028     +192     
==========================================
+ Hits         3234     3372     +138     
- Misses        602      656      +54     

see 188 files with indirect coverage changes

@ahiuchingau ahiuchingau requested a review from sfoster1 January 19, 2024 17:13
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think the upload path for the simulators can just be done with shell globbing, might be a bit simpler, but that's a small thing

uses: actions/upload-artifact@v4
with:
name: ${{ matrix.target }}-simulator-${{ github.ref_name }}
path: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be ./ot3-firmware/build-host/*/simulator/*-simulator or something I think

@ahiuchingau ahiuchingau merged commit ab2b9c4 into main Jan 19, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants