-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(state-manager): update state manager python version & update dependencies #739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice ty
f576d54
to
99a6b9b
Compare
2e2e0fd
to
0147093
Compare
df13a7e
to
a5e150a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
- Coverage 84.30% 83.71% -0.60%
==========================================
Files 87 101 +14
Lines 3836 4028 +192
==========================================
+ Hits 3234 3372 +138
- Misses 602 656 +54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I think the upload path for the simulators can just be done with shell globbing, might be a bit simpler, but that's a small thing
uses: actions/upload-artifact@v4 | ||
with: | ||
name: ${{ matrix.target }}-simulator-${{ github.ref_name }} | ||
path: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be ./ot3-firmware/build-host/*/simulator/*-simulator
or something I think
Our OT3 is running on Python 3.10 now, this means the state manager environment should also reflect that.
Changelog
main-setup
Github action that installs the required version of gcc and python for reusabilitycross-compile-all
: build/format/lint all firwmare executable targets in parallelbuild-simulators
: build simulators for targets and upload them as artifactsbuild-tests
: build-and-testThis hopefully makes it easier for us to add firmware targets/update dependencies in the future.