Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(motor-control): z stage falls after being disengaged #733

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix(motor-control): z stage falls after being disengaged #733

merged 2 commits into from
Nov 15, 2023

Conversation

ahiuchingau
Copy link
Contributor

This worked somehow? Need way more testing to verify this fix

@ahiuchingau ahiuchingau changed the title fixing 96-chan from dropping when homing ?! fixing 96-chan dropping issue when homing ?! Nov 8, 2023
caila-marashaj
caila-marashaj approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@caila-marashaj caila-marashaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

riveting

@ahiuchingau ahiuchingau marked this pull request as ready for review November 15, 2023 19:52
@ahiuchingau ahiuchingau changed the title fixing 96-chan dropping issue when homing ?! fix(motor-control): z stage falls after being disengaged Nov 15, 2023
@ahiuchingau ahiuchingau force-pushed the fix_z-dropping-when-home branch from 1040faa to b30a4d1 Compare November 15, 2023 21:47
sfoster1
sfoster1 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ahiuchingau ahiuchingau merged commit 886ae96 into main Nov 15, 2023
26 of 28 checks passed
ahiuchingau added a commit that referenced this pull request Nov 27, 2023
@ahiuchingau
fix(motor-control): z stage falls after being disengaged (#733)
f9f8885 
Adding a delay before disengaging the motor
ahiuchingau added a commit that referenced this pull request Nov 28, 2023
@ahiuchingau
fix(motor-control): only add a delay before disengaging motor if ebra…
de7fbaf 
…ke exists (#734)

* fix(head): engage head ebrake at boot (#732)

* fix(motor-control): z stage falls after being disengaged (#733)

* only adds delay if there is an ebrake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caila-marashaj caila-marashaj caila-marashaj approved these changes

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahiuchingau @sfoster1 @caila-marashaj