-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only autmomatically notify about low throughput tip changes #730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice this LGTM but we should also not enable the IRQ for the tip sense interrupt on the 96ch (in nvic_priority_enable_init
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me if tested and works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
On the 96 channel pipette, readings of the tip presence sensor are only meaningful when the gear motors are moved down far enough to drop the shroud below the optical sensor. If tips are accidentally dropped during a protocol, we wouldn't actually know until we check by commanding the gear motors to move. Therefore, we don't need an interrupt for changes in the 96 channel's sensor status.
Changelog
primary
orsecondary
sensor, as this only applies to the 96 channel