Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only autmomatically notify about low throughput tip changes #730

Merged
merged 11 commits into from
Oct 16, 2023

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Oct 13, 2023

Overview

On the 96 channel pipette, readings of the tip presence sensor are only meaningful when the gear motors are moved down far enough to drop the shroud below the optical sensor. If tips are accidentally dropped during a protocol, we wouldn't actually know until we check by commanding the gear motors to move. Therefore, we don't need an interrupt for changes in the 96 channel's sensor status.

Changelog

  • Initialize the tip presence sensor for the 96 channel as a regular gpio input, and keep interrupt initialization for the single and 8 channel pipettes
  • Remove the check in the interrupt's callback for whether the gpio pin is the primary or secondary sensor, as this only applies to the 96 channel
  • Invert the active setting of the gpio pin only for the 96 channel, so the 96 channel's response logic matches the single and 8 channel's

@caila-marashaj caila-marashaj marked this pull request as ready for review October 16, 2023 19:37
Copy link
Contributor

@fsinapi fsinapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice this LGTM but we should also not enable the IRQ for the tip sense interrupt on the 96ch (in nvic_priority_enable_init)

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if tested and works!

Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caila-marashaj caila-marashaj merged commit 01859ad into main Oct 16, 2023
@caila-marashaj caila-marashaj deleted the dont-send-tip-change-notifs-96 branch October 16, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants