feat(pipettes): require overpressure for 500ms before error #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of the overpressure warning is to avoid damage to the pressure sensor. The sensor will only give us a reading up to ~8kPa, but the actual pressure it can withstand is far higher. In an effort to avoid overeager protocol-ending errors, we are adding a requirement that the pressure remains over the threshold for at least 500MS before throwing an error.
This PR also adds reporting of any readings over the threshold.
Tested on Flexy by blocking the pipette nozzle while aspirating/dispensing. You can see in the can logs that you get a bunch of Pressure Reading responses before they start including error messages. Short aspiration/dispense distances don't have enough time to trigger the error.